Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

Wire up automated cross browser testing #113

Open
rickr opened this issue Jun 8, 2017 · 8 comments
Open

Wire up automated cross browser testing #113

rickr opened this issue Jun 8, 2017 · 8 comments

Comments

@rickr
Copy link
Contributor

rickr commented Jun 8, 2017

Feature

Why is this feature being added?

Most likely developers are adding features and testing in one browser. We should have an automated check to make sure the functionality is the same across browsers.

What should your feature do?

In a perfect world I would love to see something that upon a new PR (or update to a PR) looks at the files changed and attaches screenshots (or a link to screenshots) of the pages across the major mobile and desktop browsers. Does browserstack cover this or at least come close?

@hollomancer
Copy link
Member

Sauce Labs and Browserstack provide functionality like this.

@rickr
Copy link
Contributor Author

rickr commented Jun 9, 2017

We now have a browserstack account.

We still need more detail on how this is implemented. Ideally when a new PR comes in we would have browserstack run some tests/take some screenshots and report its status to said PR.

@kylemh kylemh modified the milestone: [Priority: 5] Design-minded Refactor Jul 15, 2017
@sethbergman
Copy link
Member

sethbergman commented Aug 6, 2017

Do we have a testing framework in mind? Mocha maybe? I know jest is in there by default. I would like to use a good testing library that is easy to write.

Sent from my Samsung SM-S120VL using FastHub

@hollomancer
Copy link
Member

Now we just need someone to write some automated UI tests :)

@kylemh
Copy link
Member

kylemh commented Oct 22, 2017

#327 💃

@kylemh
Copy link
Member

kylemh commented Oct 22, 2017

As for resolving the issue, I think implementing some documentation on using Browser Stack would be good enough to close this.

@dmarchante
Copy link
Contributor

@kylemh can this be closed due to your testing implementation for the new repo?

@kylemh
Copy link
Member

kylemh commented Aug 22, 2018

No. We need the BrowserStack account information @hollomancer

Once acquired, we can draw up instructions on eyeballing certain browsers on a release basis. We can't exactly share our account out so I think drafting up this methodology is best. It's tough to automate this.

chrisgalvan pushed a commit to chrisgalvan/operationcode_frontend that referenced this issue Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants