Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old savegames may not load #1289

Open
boris768 opened this issue Dec 5, 2020 · 1 comment
Open

Old savegames may not load #1289

boris768 opened this issue Dec 5, 2020 · 1 comment
Assignees
Labels
Confirmed Reproduced but not fixed yet

Comments

@boris768
Copy link

boris768 commented Dec 5, 2020

If savegame from original game was edited in X-Com Hack, it can cause OpenXcom crash on loading (original game is not).
There are two saves in the archive, GAME2 - before editing, GAME3 - after editing.
xcom1.zip

Crashing here, base number for first alien is 20, but really there is one base. Original game just ignores invalid save data and dont crash. Please, add nullptr check and warning message here.
https://github.com/OpenXcom/OpenXcom/blob/master/src/Savegame/SaveConverter.cpp#L805

@SupSuper SupSuper self-assigned this Dec 5, 2020
@MeridianOXC
Copy link
Member

In my opinion, this is not in scope of OpenXcom.

What do you think @SupSuper ?

@MeridianOXC MeridianOXC added the Confirmed Reproduced but not fixed yet label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Reproduced but not fixed yet
Projects
None yet
Development

No branches or pull requests

3 participants