Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black line bug #1629

Open
yohjimane opened this issue Mar 6, 2024 · 2 comments
Open

Black line bug #1629

yohjimane opened this issue Mar 6, 2024 · 2 comments
Labels
Bug The issue in the run-time. Renderer

Comments

@yohjimane
Copy link
Contributor

yohjimane commented Mar 6, 2024

Describe the bug
Seemingly based on camera angle, black line(s) can appear on the screen. Reproducing is extremely difficult unless you randomly see it happen, and can focus your mouse on the exact position. In the attached video, i had to turn my mouse sensitivity down to .001 to pin down the spot.

I did also capture this in renderdoc, in OXR Gunslinger installation, but unfortunately we didn't find any clues as to what the issue is there.

To Reproduce
Steps to reproduce the behavior:

  1. Get really lucky

Expected behavior
There shouldn't be any black lines

Screenshots, videos

S.T.A.L.K.E.R.Call.of.Pripyat.2024.03.06.-.12.02.44.38.DVR_edit_smaller.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • OpenXRay (04a805a)

Additional context
So far I've only been able to repro the issue on r4 with new_shader_support enabled. Not sure if it's an issue on other renders / vanilla r4

@yohjimane yohjimane added the Bug The issue in the run-time. label Mar 6, 2024
@SkyLoaderr
Copy link
Contributor

As a temporary solution, you can change the hbox_verts[24] variable (in Layers/xrRender/dxEnvironmentRender.cpp) by replacing

    {-1.f, 0.f, -1.f}, {-1.f, -1.f, -1.f},  // half
    {1.f, 0.f, -1.f}, {1.f, -1.f, -1.f},    // half
    {1.f, 0.f, 1.f}, {1.f, -1.f, 1.f},      // half
    {-1.f, 0.f, 1.f}, {-1.f, -1.f, 1.f}     // half

with

    {-1.f, -0.01f, -1.f}, {-1.f, -1.f, -1.f},  // half
    {1.f, -0.01f, -1.f}, {1.f, -1.f, -1.f}, // half
    {1.f, -0.01f, 1.f}, {1.f, -1.f, 1.f}, // half
    {-1.f, -0.01f, 1.f}, {-1.f, -1.f, 1.f} // half

@yohjimane
Copy link
Contributor Author

@SkyLoaderr I just tested this out, and it seems to work! Any idea what a more permanent solution would look like?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug The issue in the run-time. Renderer
Projects
Status: To do
Development

No branches or pull requests

3 participants