Angular RecordingService makes incorrect assumptions about recording path

[lierdakil]

See subject. The assumption is the recording path is <session_id>/<session_id>.mp4, but it is, in fact, <session_id>/<REC_NAME>.mp4.

openvidu/openvidu-components-angular/projects/openvidu-angular/src/lib/services/recording/recording.service.ts

Line 80 in 918bf0a

`${this.baseUrl}recordings/${recordingId}/${recordingId}.${extension}${queryParamForAvoidCache}`

openvidu/openvidu-components-angular/projects/openvidu-angular/src/lib/services/recording/recording.service.ts

Line 94 in 918bf0a

link.href = `/recordings/${recordingId}/${recordingId}.${extension}`;

This affects both play and download actions. A better approach may be to just use url verbatim, chopping off everything up to and including /openvidu/, and plopping the rest as the video URL, i.e. if url as reported in RecordingInfo is https://foo.com/openvidu/recordings/... you could just string.replace(/^.*?/openvidu/$/, '/').

Furthermore, it makes equally incorrect, but in some sense the inverse assumption about thumbnail names: apparently, it assumes thumbnail names are <rec_name>/<rec_name>.jpg (by taking the last component of the video url), but they are, in fact, <session_id>/<session_id>.jpg. A better approach is to perhaps construct the thumbnail url the way the video url is currently constructed, i.e. as ${baseUrl}recordings/${recording.id}/${recording.id}.jpg

openvidu/openvidu-components-angular/projects/openvidu-angular/src/lib/pipes/recording.pipe.ts

Lines 62 to 71 in 918bf0a

	export class ThumbnailFromUrlPipe implements PipeTransform {
	transform(url: string): string {
	const lastPart = url.split('/').pop();
	const isMp4 = url.includes('.mp4');
	if (!lastPart || !isMp4) return url;
	return `recordings/${lastPart.split('.')[0]}/${lastPart.replace('mp4', 'jpg')}`;
	}
	}