Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Updates on admin port are unreliable #12575

Open
npabisz opened this issue Apr 25, 2024 · 1 comment
Open

[Bug]: Updates on admin port are unreliable #12575

npabisz opened this issue Apr 25, 2024 · 1 comment
Labels
needs triage This issue needs further investigation before it becomes actionable

Comments

@npabisz
Copy link

npabisz commented Apr 25, 2024

Version of OpenTTD

14.0

Expected result

Updates (automatic) from admin port always been unreliable, like sometimes you would get clientinfo, clientupdate and sometimes not. I've noticed that 14.0 brings even less reliability on them. Eg. after client creates company and join it there is no clientupdate, I need to pull that manually. This breaks my game scripts. I'd except to get update every time any of the (topic) fields does change.

Actual result

There is no updates of client eg. after he joined company.

Steps to reproduce

  1. Listen to admin port
  2. Set automatic pull for client updates
  3. Join the game with new client
  4. Create new company
  5. There is no clientupdate event
@npabisz npabisz changed the title [Bug]: Updates on admin port are random [Bug]: Updates on admin port are unreliable Apr 25, 2024
@2TallTyler 2TallTyler added the needs triage This issue needs further investigation before it becomes actionable label May 7, 2024
@MuxyDuGoulp
Copy link
Contributor

MuxyDuGoulp commented May 10, 2024

can't reproduce what you describe

  1. Connect to admin port with bot : Ok
  2. automatic pull for client update is set : Ok
  3. join the game with a client as spectator : Ok
  4. create new company => CLIENT_UPDATE received

here is my bot log

2024-05-10 18:52:29 S2(1):server_do_packet Admin_Packet_ServerClientInfo
2024-05-10 18:52:29 S2(1):Server - Client infos 708 <IP-MASKED> Muxy
2024-05-10 18:52:29 S2(1):Server - Client Infos No client 708
2024-05-10 18:52:29 S2(1):Server - Client Infos 708 update <IP-MASKED> Muxy
<database log removed>
2024-05-10 18:52:29 S2(1):idclient 1080 client.id_client 1080
<database log removed>
2024-05-10 18:52:29 S2(1):server_do_packet Admin_Packet_ServerClientJoin
2024-05-10 18:52:29 S2(1):Client join  708
2024-05-10 18:52:29 S2(1):Welcome:About to welcome Muxy, lang fr, id 1
2024-05-10 18:52:29 S2(1):Welcome:message list is 6
<tchat welcome message removed>
2024-05-10 18:52:35 S2(1):server_do_packet Admin_Packet_ServerCompanyNew
2024-05-10 18:52:35 S2(1):New Company : 1
2024-05-10 18:52:35 S2(1):Company Count 3
2024-05-10 18:52:35 S2(1):server_do_packet Admin_Packet_ServerCompanyInfo
2024-05-10 18:52:35 S2(1):Company Infos 1 Non nommé D. Murphy
<database log removed>
2024-05-10 18:52:35 S2(1):server_do_packet Admin_Packet_ServerCompanyUpdate
2024-05-10 18:52:35 S2(1):Company Update : 1 Non nommé D. Murphy
<database log removed>

2024-05-10 18:52:35 S2(1):server_do_packet Admin_Packet_ServerClientUpdate
2024-05-10 18:52:35 S2(1):Client update 708 Muxy 1
2024-05-10 18:52:35 S2(1):Client Update 708 update Muxy 1
2024-05-10 18:52:35 S2(1):chat : Muxy join company Non nommé

2024-05-10 18:52:35 S2(1):server_do_packet Admin_Packet_ServerChat
2024-05-10 18:52:35 S2(1):server_do_packet Admin_Packet_ServerCompanyUpdate
2024-05-10 18:52:35 S2(1):Company Update : 1 Muxy Transport Muxy
<database log removed>
2024-05-10 18:52:35 S2(1):server_do_packet Admin_Packet_ServerCompanyUpdate
2024-05-10 18:52:35 S2(1):Company Update : 1 Muxy Transport Muxy
<database log removed>
2024-05-10 18:52:35 S2(1):server_do_packet Admin_Packet_ServerCompanyUpdate
<database log removed>

and each time the client switches company, the packet is received by my bot

do you have a log in your bot ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue needs further investigation before it becomes actionable
Projects
None yet
Development

No branches or pull requests

3 participants