Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scroll bug when chat is opened (the same issue was for menu) #21405

Merged

Conversation

RaushanSakhibzadin
Copy link
Contributor

Fixes #21344

Added conditions to halt scrolling when chat is opened

The same issue was for opening and closing the menu:
while holding any arrow key, open the menu, release the key, close the menu
the camera keeps moving

Best regards,
Raushan Sakhibzadin

Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash the commits

@RaushanSakhibzadin RaushanSakhibzadin force-pushed the scroll_bug_when_chat_is_opened branch 2 times, most recently from 43ab35e to 95f4f0d Compare April 30, 2024 08:36
@PunkPun PunkPun merged commit 106c184 into OpenRA:bleed Apr 30, 2024
3 checks passed
@PunkPun
Copy link
Member

PunkPun commented Apr 30, 2024

changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll bug when chat is opened
3 participants