Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment_flatten can be executed using qemu-img commit instead of qemu-img convert #6547

Open
3 tasks
nachowork90 opened this issue Mar 22, 2024 · 1 comment
Open
3 tasks

Comments

@nachowork90
Copy link

Description
The goal is shorten the time and I/O required to merge the full and the next incremental on the chain when the keep_last value reached.

Use case
When we execute the qemu-img commit on the top file that point to the base image (backing_file) or full image in this case. Only the changes of the incremental goes to override the clusters in the base image, even if there are more than 1 elements in the chain.

Interface Changes
remotes/datastore/rsync/increment_flatten to modify the function merge_chain call
remotes/tm/lib/backup.rb to add a new function the handle this scenario.

Additional Context
Operations performed in the rsync host:

qemu-img commit -f qcow2 '/var/lib/one/datastores/100/7/768671/disk.0.3'                                                                                                                │·
mv '/var/lib/one/datastores/100/7/2757f7/disk.0.0' '/var/lib/one/datastores/100/7/768671/disk.0.3'

Progress Status

  • Code committed
  • Testing - QA
  • Documentation (Release notes - resolved issues, compatibility, known issues)
@Franco-Sparrow
Copy link

Franco-Sparrow commented Mar 22, 2024

This has a storage and backup time saving approach. Awsome nacho :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants