Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileConverter fails for symlinked raw input #7439

Open
bernt-matthias opened this issue Apr 12, 2024 · 5 comments
Open

FileConverter fails for symlinked raw input #7439

bernt-matthias opened this issue Apr 12, 2024 · 5 comments

Comments

@bernt-matthias
Copy link
Contributor

For instance this test

add_test("TOPP_THERMORAWFILEPARSER_1" ${TOPP_BIN_PATH}/FileConverter -test -in ${DATA_DIR_TOPP}/THIRDPARTY/ginkgotoxin-ms-switching.raw -ThermoRaw_executable "${THERMORAWFILEPARSER_BINARY}" -out ginkgotoxin-ms-switching_out_tmp.mzML)
if the input is a link.

Consequence is that for the Galaxy tools we can't use symlinks for the input data.

@jpfeuffer
Copy link
Contributor

This is a problem with ThermoRawFileParser: compomics/ThermoRawFileParser#46

@jpfeuffer
Copy link
Contributor

@bernt-matthias
Copy link
Contributor Author

Thanks for the link. Seems that this should be solved in recent versions compomics/ThermoRawFileParser#146

@jpfeuffer
Copy link
Contributor

Yep. Not sure if we include the newest version in our conda thirdparty.

Unfortunately we are having major issues updating our thirdparty due to size limitations on mulled container tests. So, we will not be able to update them in the foreseeable future and might need to drop the thirdparty package.

@bernt-matthias
Copy link
Contributor Author

Yep. Seems to be still a problem with the latest version compomics/ThermoRawFileParser#180

bernt-matthias added a commit to bernt-matthias/tools-galaxyp that referenced this issue Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants