RawFileConverter missing binary for KNIME plugin

[poshul]

With OpenMS 3.0 and Knime 5.2 the RawFileConverter node doesn't run, and throws a "Failed to find matching binary." code. Interestingly enough FileConverter is perfectly happy to do the raw conversion so long as it knows where ThermoRawFileParser.exe is.

[jpfeuffer]

Raw file converter needs the Openms thirdparty plugin.

[poshul]

Yup. I've got that installed.

[jpfeuffer]

I don't remember the details of how this was implemented.

[poshul]

I checked the Binaries.ini for the thirdparty package, per https://github.com/genericworkflownodes/GenericKnimeNodes/wiki/How-to-handle-missing-binaries . It looks like the link to the ThermoRawFileParser folder is still there, and the folder has the executable in it.

It's not the end of the world, as I can still get the functionality by pushing the ThermoRawFileParser.exe from a file importer node to the FileConverter.

[jpfeuffer]

Failed to find matching binary means that the adapter exe is not found in the plugin.

Code is here:

OpenMS/cmake/knime_package_support.cmake

Line 228 in 7ffeae5

# Note: We expose FileConverter twice.

[jpfeuffer]

Binaries.ini are for the third party exes.
Where do you get the thermorawparser.exe from. The idea is that they are included in the knimw third party plugin. No external exe needed.

[jpfeuffer]

There probably needs to be an extra copy for FileConverter into the TPplugin here:

OpenMS/cmake/knime_package_support.cmake

Line 303 in 7ffeae5

if(${TOOL} IN_LIST THIRDPARTY_ADAPTERS)