Added usedforsecurity=False flag to hashlib.md5 uses for FIPS-enabled systems.
#3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naylor-b
approved these changes
May 15, 2024
|
@robfalck if it's only one try except I would very much appreciate keeping the support for python 3.8 at least until the end of life. My team has an action to move towards a higher version by the end of the year but for the moment we havn't quite moved yet. |
|
@andrewellis55 it's fairly easy to accommodate 3.8 here so I'll make the change. Out of curiosity, what's blocking you from upgrading to 3.9 or later? |
|
@robfalck Just scheduling. It's very firmly on the todo list and should be complete by the official 3.8 End of Life. There are a few (minor) extra steps we need to take when performing upgrades because of corporate IT policies. |
robfalck
changed the title
usedforsecurity=False flag to hashlib.md5 uses.usedforsecurity=False flag to hashlib.md5 uses for FIPS-enabled systems.
swryan
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Users of Linux systems with FIPS (Federal Information Processing Standard) enabled were unable to use OpenMDAO features which called hashlib.md5. The argument
usedforsecurity=Falseallows this code to operate, but is only available in Python >= 3.9.This change adds the
usedforsecurity=Falsetohashlib.md5calls.WIth Python 3.8 this will fall back to the previous method without the argument, so FIPS systems will need to use Python 3.9 or later.
Related Issues
Backwards incompatibilities
None
New Dependencies
None