-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added zero_tol parameter for check_partials method #3166
base: master
Are you sure you want to change the base?
Conversation
Thanks for your contribution! Would you be able to add a test for our CI that verifies that this works? It can be as simple as capturing the text from your example above and making sure it matches the expected value. |
After testing this implementation a bit, I have a few suggestions. I think Interested to hear thoughts on this. |
Not entirely sure if I understood correctly, but I just updated the to code use the norm of the Jacobian and if the norm is greater than the specified threshold (renamed zero_tol to rel_err_norm_thresh), the relative error will be computed, if it is below, it will not be computed (as you suggested). Let me know if this sounds better. |
Summary
Before:
After:
Related Issues
Backwards incompatibilities
None
New Dependencies
None