Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zero Tolerance to Check Partials for Relative Error Checks #3164

Open
andrewellis55 opened this issue Mar 26, 2024 · 0 comments · May be fixed by #3166
Open

Add Zero Tolerance to Check Partials for Relative Error Checks #3164

andrewellis55 opened this issue Mar 26, 2024 · 0 comments · May be fixed by #3166

Comments

@andrewellis55
Copy link
Contributor

Desired capability or behavior.

In some cases, derivatives are very close to 0. This can cause relative error checks to fail. It may be worth to adding a parameter zero_tol to the check_partials call that rounds the calc mag to zero if it is bellow this tolerance before comparing it to the check mag.

-------------------------------------------------------------------------------------------------------
Component: Comp 'comp'
-------------------------------------------------------------------------------------------------------
'<output>'       wrt '<variable>'        | calc mag.  | check mag. | a(cal-chk) | r(cal-chk)
--------------------------------------------------------------------------------------------

'a' wrt 'b'  | 1.4410e-17 | 0.0000e+00 | 1.4410e-17 | 1.0000e+00 >REL_TOL

Associated POEM

No response

@robfalck robfalck removed their assignment Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants