Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faults with Video 'Insert from Web' and YouTube #849

Closed
nvella opened this issue Aug 10, 2019 · 6 comments
Closed

Faults with Video 'Insert from Web' and YouTube #849

nvella opened this issue Aug 10, 2019 · 6 comments
Assignees
Labels
bug General bugs good first issue Issues which would be a good first issue for new contributors videos Issues related to video inserting, embedding or uploading

Comments

@nvella
Copy link
Member

nvella commented Aug 10, 2019

I've looked at the other issues and whilst this bug does get mentioned, nothing singles it out exactly. Creating a separate issue so it's more easily identifiable.

Two issues are currently present with YouTube videos and Video -> 'Insert from Web'

  • The form does not recognise https, or youtu.be URLs.
  • Changing the UR to a http URL results in the old Flash player being added, which is no longer functional.

The intended behavior is for https and youtu.be URLs to work in the form, and for the newer HTML5 player to be inserted, rather than the older Flash player.

@nvella nvella added bug General bugs good first issue Issues which would be a good first issue for new contributors labels Aug 10, 2019
@nvella nvella added the videos Issues related to video inserting, embedding or uploading label Aug 10, 2019
@ranjanjharavi
Copy link
Contributor

ranjanjharavi commented Oct 4, 2019

Hi, May I pick this issue. If no one is working on this then, Please assign it to me. @nvella

@nvella
Copy link
Member Author

nvella commented Oct 4, 2019

Sure Ravi 👍 Feel free to ask any questions if you need help

@ranjanjharavi
Copy link
Contributor

Thank you, Nick. :)
I tried this issue and was able to get the preview of the YouTube URLs containing https and youtu.be.
But, while publishing the post to WordPress account I was getting one exception ProgId missing for extension:: wpost and still was able to post after ignoring.
Is this problem related to build or something?
Also using VS2015 I was getting lots of errors during the build but not in VS2017 which I use in general.
@nvella Should I give PR of the branch to get reviewed?

@nvella
Copy link
Member Author

nvella commented Oct 6, 2019

Hi @ranjanjharavi,

Looks like good work so far! Certainly submit a PR and I can give it a look.

The ProgId and extension wpost errors are a known issue to-do with file associations - I'm intending to give that a look as part of my work on MSIX packaging as MSIX supposedly handles setting up associations.

As for the Visual Studio version, I've been developing on 2017, however @wforney is working on moving the project over to 2019 in #863. Don't worry if you have to change the version on your branch to develop, we can fix it up later :)

Cheers, Nick

@ranjanjharavi
Copy link
Contributor

Oh, good to know. Thank you @nvella

@nvella
Copy link
Member Author

nvella commented Oct 12, 2019

Fixed by @ranjanjharavi via #871.

@nvella nvella closed this as completed Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug General bugs good first issue Issues which would be a good first issue for new contributors videos Issues related to video inserting, embedding or uploading
Projects
None yet
Development

No branches or pull requests

2 participants