Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limit the login endpoint #28

Open
kuboschek opened this issue Nov 11, 2016 · 1 comment
Open

Rate limit the login endpoint #28

kuboschek opened this issue Nov 11, 2016 · 1 comment

Comments

@kuboschek
Copy link
Member

Currently there is no limit to the number of login requests.

A solution to this issue limits login attempts within a certain time window by both user and IP.

@tkw1536
Copy link
Member

tkw1536 commented Nov 12, 2016

We should take the proxying done by almost any deployment technique into account. In practice we will need to trust

X-FORWARDED-FOR

headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants