Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIQA server sessions endpoint doesn't use 'imagepattern' correctly #106

Open
curtislisle opened this issue Apr 29, 2021 · 1 comment
Open

Comments

@curtislisle
Copy link
Collaborator

the getSessions endpoint in the MIQA server doesn't find datasets if the filename doesn't end with .nii.gz. In particular, the imagePattern should be used here instead of the hard-coded regex:
https://github.com/OpenImaging/miqa/blob/57fdc5fee5dff86a01539a1055d3442637ff1785/server/miqa_server/session.py#L117

@curtislisle curtislisle added this to Triage (Needs Grooming) in Sprint Board (4 week) via automation Apr 29, 2021
@scottwittenburg
Copy link
Collaborator

When I wrote the json data model, I intended to put imagePattern there instead of nii.gz$, and thought I had done so, but must not have 🤷. I think the fix is as simple as just making that replacement and testing that it behaves as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Sprint Board (4 week)
  
Triage (Needs Grooming)
Development

No branches or pull requests

2 participants