Skip to content
This repository has been archived by the owner on Dec 20, 2021. It is now read-only.

Bug in TranslateString method #935

Open
PushUpek opened this issue Nov 20, 2020 · 3 comments
Open

Bug in TranslateString method #935

PushUpek opened this issue Nov 20, 2020 · 3 comments
Labels
Bug Something isn't working Low Priority For issues that are nice to have, but not essential.

Comments

@PushUpek
Copy link
Contributor

Describe the bug
There is a problem with the TranslateString method in the asset manager. When a key exists in another *.tbl. We only get the first appearance. Keys like # + idx have duplicates. So we have no control over which table we get the translation from.

@gravestench
Copy link
Contributor

gravestench commented Dec 21, 2020

I'll agree that there are identical keys in multiple tables, but I don't feel that this is an issue. The MPQ's share many files, and the load-order of the MPQ determine's which file is used (this is by blizzard's design).

This is just a hunch, but I think the real issue here is the order in which we load all of the string tables.

@PushUpek Do you have an example of a particular key+string and which possible tables it can come from vs where it should come from?

@gravestench gravestench added Bug Something isn't working Low Priority For issues that are nice to have, but not essential. labels Dec 21, 2020
@gravestench gravestench added this to To do in OpenDiablo 2 Game Engine via automation Dec 21, 2020
@gucio321
Copy link
Contributor

see d2game/d2gamescreen/select_hero_class.go:706

                // here is a problem with polish language: in polish string table, there are two items with key "#304"

@gucio321
Copy link
Contributor

Instead of druid description, we can see some string from battle.net game (sth like "character with name %s already exists in this realm")

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something isn't working Low Priority For issues that are nice to have, but not essential.
Projects
Development

No branches or pull requests

3 participants