Skip to content
This repository has been archived by the owner on Dec 20, 2021. It is now read-only.

File Encoders for all file formats in `d2common/d2fileformats/ #909

Open
gravestench opened this issue Nov 8, 2020 · 1 comment
Open
Labels
Enhancement New feature or request Good First Issue Good for newcomers Help Wanted Extra attention is needed Normal Priority For issues that are essential, but are not on the critical path or blocking development in any way

Comments

@gravestench
Copy link
Contributor

We currently only have file decoders in d2fileformats. Most of the Load functions take a byte slice as an argument, and parse the bytes into a struct for that file type. We need to be able to convert a struct instance back to a byte slice.

@gravestench gravestench added Enhancement New feature or request Help Wanted Extra attention is needed Good First Issue Good for newcomers Normal Priority For issues that are essential, but are not on the critical path or blocking development in any way labels Nov 8, 2020
@rjnienaber
Copy link

I did a cursory check and it seems like d2dcc and d2mpq are the only file formats that still require a .Marshal method. Is this required for those formats? If so, I'd like to take a shot at the .dcc one but I don't have an example file that I could commit to the repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement New feature or request Good First Issue Good for newcomers Help Wanted Extra attention is needed Normal Priority For issues that are essential, but are not on the critical path or blocking development in any way
Projects
None yet
Development

No branches or pull requests

2 participants