Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Looks at DDS Guid_t/InstanceHandle_t conversion #2

Open
jwillemsen opened this issue Dec 14, 2018 · 5 comments
Open

Looks at DDS Guid_t/InstanceHandle_t conversion #2

jwillemsen opened this issue Dec 14, 2018 · 5 comments

Comments

@jwillemsen
Copy link
Member

The other rmw implementations use built in discovery to cache data related to participant/topic based on DDS::Guid_t, need to check how this should be done with OpenDDS
@lij-oci lij-oci mentioned this issue Mar 31, 2020
Closed
@adamsj-ros
Copy link
Contributor

@mitza-oci, @kuznetsovmoci, and @lij-oci, Do we need to address this issue?

@mitza-oci
Copy link
Member

Would someone please add a link to the line(s) of code impacted?

@jwillemsen
Copy link
Member Author

Within the rmw_connext this is done in https://github.com/ros2/rmw_connext/blob/7781a5e5982032be9460840e33646028af21129e/rmw_connext_shared_cpp/include/rmw_connext_shared_cpp/guid_helper.hpp#L63, within that implementation I found caching based on DDS_Guid_t instead of using DDS_InstanceHandle_t

@jwillemsen
Copy link
Member Author

See also ros2/rmw_connext#326

@mitza-oci
Copy link
Member

In this repository, looks like the TopicCache was changed to use InstanceHandle_t. What else, if anything, needs to be done (in this repository) to implement the required RMW functions?

@jwillemsen jwillemsen mentioned this issue Jun 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jwillemsen @mitza-oci @adamsj-ros