Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX on treeview #817

Open
mielvds opened this issue Mar 28, 2023 · 3 comments
Open

Improve UX on treeview #817

mielvds opened this issue Mar 28, 2023 · 3 comments

Comments

@mielvds
Copy link
Contributor

mielvds commented Mar 28, 2023

The tree view uses left click to expand and right click to open a concept page, which is cumbersome on a mac. A left click requires Command + Double click (single click opens a browser menu) and you need to hit the little circle. This is particulary inconvienent on https://thesaurus.onroerenderfgoed.be where the treeview is your only means of navigation when opening a conceptscheme.

Some thoughts:

  • Switching right and left click feels more intuitive (to me)
  • The circle and text should be bigger and it should be clearer which elements are clickable (eg. hover or link style)
  • It would help to add an explicit collapse/expand button, or open the page when you click the text, so you only need a left click
  • Consider an update of the tree component: new look&feel or perhaps a treemap works better

I can to have a crack at this a create a PR if desired

@JonasGe
Copy link
Member

JonasGe commented Mar 29, 2023

The tree view uses left click to expand and right click to open a concept page, which is cumbersome on a mac. A left click requires Command + Double click (single click opens a browser menu) and you need to hit the little circle.

Could you elaborate on this? Right click with two fingers on my Mac doesn't seem too cumbersome to open a concept page.
I can't reproduce what you mean with Cmd + double click (it zooms in on the tree when I do that).

That being said, you're always welcome to propose a more user-friendly tree view. If you can make it work with only left clicks, that would definitely improve the user experience.

@mielvds
Copy link
Contributor Author

mielvds commented Mar 29, 2023

Hi @JonasGe. Thanks for the feedback. It's odd, because now the right click works on my Magic Mouse and the double click doesn't 🤷 It's probably something with my old mouse then.

That said, we will probably work on some enhanced version for our instance, so all the better if general atramhasis can profit. I'll open a PR once I find some time for a fun side project.

@mielvds mielvds changed the title Treeview has poor UX on MacOs Improve UX on treeview Mar 29, 2023
@koenedaele
Copy link
Member

Looking at the code for the tree, it's not the cleanest code we have. Seems to be heavily tied to HTML template. I'm no frontend dev, but I do assume it can be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants