Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File to import not found when using Compass to compile SCSS files #727

Open
mielvds opened this issue Sep 9, 2022 · 3 comments
Open

File to import not found when using Compass to compile SCSS files #727

mielvds opened this issue Sep 9, 2022 · 3 comments

Comments

@mielvds
Copy link
Contributor

mielvds commented Sep 9, 2022

Hi!

I'm getting the following errors when running compass compile in the static folder.

error scss/app-admin.scss (Line 4: File to import not found or unreadable: foundation.
error scss/app.scss (Line 4: File to import not found or unreadable: foundation.

Should

@import "foundation";
be atramhasis/foundation/functions?

If I make this change, I get the same complaint for font-awesome on

@import "font-awesome";

A side question: would it valuable to switch from compass to something like pyscss and remove the Ruby dependency and perhaps do this conversion at startup?

@koenedaele
Copy link
Member

I'm going to have to pass this on to the frontend team. I think we do stuff very differently these days.

@JonasGe
Copy link
Member

JonasGe commented Sep 9, 2022

Hi Miel, did you run npm install before compiling the SCSS? This should install font-awesome and foundation.

In other projects, we have made the switch from NPM to yarn which can also handle the SCSS compilation.

We should look into transitioning to our more modern tech stack (python back-end, typescript/Aurelia front-end) for this application too. Or migrate the front-end to Vue.js as an experiment... @cedrikv

@mielvds
Copy link
Contributor Author

mielvds commented Sep 10, 2022

Hi Miel, did you run npm install before compiling the SCSS? This should install font-awesome and foundation.

I didn't at first, but then it was complaining about https://github.com/OnroerendErfgoed/atramhasis/blob/develop/atramhasis/static/config.rb#L2

In other projects, we have made the switch from NPM to yarn which can also handle the SCSS compilation.

That fixed it acutally, thanks! Perhaps put yarn forward in the docs as well

We should look into transitioning to our more modern tech stack (python back-end, typescript/Aurelia front-end) for this application too. Or migrate the front-end to Vue.js as an experiment... @cedrikv

Compared to other open-source, java-heavy SKOS projects, I think this stack is already quite modern :D
Migrating the front-end to something like Vue is probably a good idea, but not sure how big of an effort it would be. Are you considering changing the backend as well? Happy to help/brainstorm in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants