Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AffineTransform should not center data upfront #8

Open
Oliver-Loeffler opened this issue Sep 7, 2019 · 1 comment
Open

AffineTransform should not center data upfront #8

Oliver-Loeffler opened this issue Sep 7, 2019 · 1 comment
Assignees
@Oliver-Loeffler
Labels
enhancement New feature or request
Milestone
0.0.6

Comments

@Oliver-Loeffler
Copy link
Owner

The AffineTransformCalculation function centers the given data before doing any calculations. There are cases, where this centering is not wanted. To cover those cases, try following approach:

  • remove the centering code from AffineTransformCalculation and instead compose it with a variant of net.raumzeitfalle.registration.alignment.TranslateToCenter.
  • A new version of TranslateToCenter is needed, as the center calculation should be controlled by a Predicate<Displacement>.
@Oliver-Loeffler Oliver-Loeffler added the enhancement New feature or request label Sep 7, 2019
@Oliver-Loeffler Oliver-Loeffler self-assigned this Sep 7, 2019
@Oliver-Loeffler
Copy link
Owner Author

The translation step is not yet controlled by a predicate but moved into a separate function.
Since e524e5a.

@Oliver-Loeffler Oliver-Loeffler added this to the 0.0.6 milestone Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Oliver-Loeffler Oliver-Loeffler

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.0.6
Development

No branches or pull requests
1 participant
@Oliver-Loeffler