Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple testing correction in olink_one_non_parametric_posthoc outside the group_by #346

Open
klevdiamanti opened this issue Apr 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@klevdiamanti
Copy link
Contributor

klevdiamanti commented Apr 2, 2024

Describe the bug
In the function olink_one_non_parametric_posthoc the BH multiple testing correction is done inside the group_by and before ungroup.

To Reproduce
Steps to reproduce the behavior:

  1. Check lines 218-221 and 235-238 in file Olink_one_non_parametric.R to see how it is done for olink_one_non_parametric
  2. Check lines 393-394 and 407-409 in file Olink_one_non_parametric.R to see how it is done for olink_one_non_parametric_posthoc

Expected behavior
BH correction should be performed after data is ungrouped.

System Information:

  • OS: all
  • R Version: all

Additional context
Remove BH correction from rstatix::wilcox_test and FSA::dunnTest, and perform it after ungrouping using stats::p.adjust. Also make sure to keep both raw and adjusted p-value in the output.

@klevdiamanti klevdiamanti added the bug Something isn't working label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant