Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 [REQUEST] - is_iconsmap module #324

Open
8 tasks
Oksydan opened this issue Nov 4, 2023 · 2 comments
Open
8 tasks

馃殌 [REQUEST] - is_iconsmap module #324

Oksydan opened this issue Nov 4, 2023 · 2 comments

Comments

@Oksydan
Copy link
Owner

Oksydan commented Nov 4, 2023

Summary

We are moving from material icons to svg sprite generated icons via php code.

TO DO:

  • - create new module with form and grid in BO
  • - allow to set name of an icons (identifier name used as icon key)
  • - allow to set alias for given icon (multiple keys for one icon)
  • - allow to upload svg icon (sanitize svg)
  • - allow to enable and disable icon
  • - we have to save into the database information about viewbox of an icon
  • - svg sprite will be generated every time we change something in BO or configuration
  • - icons in front end will be consumed by smarty function

Feature target required module/theme

is_iconsmap

@maofree
Copy link
Sponsor

maofree commented Nov 22, 2023

Hi @Oksydan
I have some doubts about svg incons

which solution is better between?:

probably Embedded solution is faster, but if an icon svg ir repeated 2-3 times probably is better CSS or External image .svg?
or many times like for add to cart icon in the category pages

thanks

@Oksydan
Copy link
Owner Author

Oksydan commented Nov 23, 2023

Hi @maofree,

don't worry about repeating anything. We are going to create svg sprite and reference that icon in svg tag. There will be no icons repetition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants