Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Icon is not working #1236

Open
hieu-nv opened this issue Sep 6, 2020 · 1 comment
Open

Edit Icon is not working #1236

hieu-nv opened this issue Sep 6, 2020 · 1 comment

Comments

@hieu-nv
Copy link

hieu-nv commented Sep 6, 2020

ms-Icon--Edit is not exists in fabric.css after I built source.
@sayers24
Copy link
Contributor

Looks like the edit icon (among others) are now scoped under a [dir='ltr'] selector. Adding this somewhere in your markup should mitigate the issue. This does not solve if anyone wants to use dir="auto". I have created a PR so ms-Icon--Edit can be freely used without risk of an icon missing in the UI. PR: #1242

@sayers24 sayers24 mentioned this issue Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sayers24 @hieu-nv