Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaskPane Outlook JS App npm run lint fails #822

Open
GrumpyAL opened this issue Apr 24, 2024 · 2 comments
Open

TaskPane Outlook JS App npm run lint fails #822

GrumpyAL opened this issue Apr 24, 2024 · 2 comments

Comments

@GrumpyAL
Copy link

Expected behavior

When running npm run lint on a freshly generated add-in, the linting runs successfully.

Current behavior

After generating a fresh TaskPane Outlook JavaScript add-in and running npm run lint an error is encountered. When I started opening this bug, the error was

error Parsing error: Cannot read file '[path]\tsconfig.json'

However, after trying different node versions and generating new add-ins I was unable to reproduce because I got this error instead
ESLint couldn't find the plugin "eslint-plugin-office-addins". (The package "eslint-plugin-office-addins" was not found when loaded as a Node module from the directory "[path]\node_modules\office-addin-lint\lib".)

It turns out, that the package office-addin-lint was updated a day ago to 2.3.1 and is what produces the new error. If you install back to 2.3.0, then you get the first error about missing the tsconfig file.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Use the generator to make a new add-in with the following settings:
  • TaskPane
  • Outlook
  • JavaScript
  1. Open VSCode and run npm run lint in the terminal.
  2. Observe one of two errors depending on the version of office-addin-lint.
  3. Install the other version and repeat.

Context

Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Operating System: Windows
  • Node version: Tried various, currently 20.1.2.
  • Office version: n/a but 2403
  • Tool version: 5.0.0 (installed again and confirmed updating it didn't fix the issue).
@davidchesnut
Copy link
Member

Hi @GrumpyAL, thanks for reporting this! I see this issue as well. @millerds, can you please help with this issue? Thanks!

@millerds
Copy link
Contributor

This seems to have been broken with an update to our lint rules package. A fix needs to be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants