Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERROR] tests broken with this module. #29

Open
nhomar opened this issue May 24, 2015 · 1 comment
Open

[ERROR] tests broken with this module. #29

nhomar opened this issue May 24, 2015 · 1 comment

Comments

@nhomar
Copy link

nhomar commented May 24, 2015

Hello.

It is great if this kind of modules do not brake official tests, then if you face this problem and you know what should be the roadmap it should be cool and we can make a PR.

Basically:

  1. Configure the repository to use OCA estandars (.travis, flake and pylint.
  2. When it is installed you will face this error on unit tests:
2015-05-24 10:27:57,937 24837 INFO openerp_test openerp.tests.common: phantomjs: Can't reach the next step

2015-05-24 10:27:57,937 24837 INFO openerp_test openerp.tests.common: phantomjs:  tour: shop

2015-05-24 10:27:57,938 24837 INFO openerp_test openerp.tests.common: phantomjs:  step: 7: 'Update image'

2015-05-24 10:27:57,938 24837 INFO openerp_test openerp.tests.common: phantomjs:  href: http://localhost:8069/shop/product/new-product-65?enable_editor=1

2015-05-24 10:27:57,939 24837 INFO openerp_test openerp.tests.common: phantomjs:  referrer: http://localhost:8069/

2015-05-24 10:27:57,939 24837 INFO openerp_test openerp.tests.common: phantomjs:  element: false

2015-05-24 10:27:57,939 24837 INFO openerp_test openerp.tests.common: phantomjs:  waitNot: true

2015-05-24 10:27:57,940 24837 INFO openerp_test openerp.tests.common: phantomjs:  waitFor: true

2015-05-24 10:27:57,941 24837 INFO openerp_test openerp.tests.common: phantomjs:  localStorage: {"tour":"{\"id\":\"shop\",\"mode\":\"test\",\"step_id\":6,\"time\":1432463270939,\"number\":2,\"wait\":0}"}

Regards.

@lukebranch
Copy link

@nhomar ,

Thanks for your interest in this module. I haven't yet run any unit tests on this repository, however i'll get working on this as soon as possible.

I was planning on waiting to do more work on this module until OCA/product-attribute/product_images (OCA/product-attribute#42) was ported to 8.0, as it allows for storing the images on in the filesystem, and handles the storage of multiple product images better overall. I will then rewrite the UI to read the images from this module. This will allow for those with large product catalogs to keep their databases lean.

I'll work on getting these errors resolved as soon as possible so that I can make a PR for OCA/website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants