Push existing package - package id not correctly derived when OverwriteExisting with DeltaCompression and double extension.

[octocrock]

When pushing a package, double extensions will always fall back to push the entire package if the package has a double extension - .tar.gz, tar.bz.

It looks like it's this line; Path.GetFileNameWithoutExtension(fileName) does not work on double file extensions.

---

Tested using Octopus CLI.

• First command - push package for first time
• Second command - push the same package

Test 1

Package is identified as existing, --overwrite-mode using default of FailIfExists:

Test 2

--overwrite-mode using OverwriteExisting. Default of --use-delta-compression is true, here it cannot identify the package id, so falls back to the full upload:

[gupta-kartik]

https://trello.com/c/LhtnURYW/4072-push-existing-package-package-id-is-not-correctly-derived-when-overwriteexisting-with-deltacompression-and-double-extension-targ

[mcasperson]

We have flagged this as an issue with product, but at this point we do not have capacity to assign an engineer to resolve the issue. We'll keep the issue open, but unfortunately we can not provide any guidance as to when it will be resolved.

[yj7o5]

@mcasperson I can send a PR for this if you like!