Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus instrumentation to Reconcile #16

Open
danieloliveira079 opened this issue Nov 25, 2021 · 0 comments
Open

Add Prometheus instrumentation to Reconcile #16

danieloliveira079 opened this issue Nov 25, 2021 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@danieloliveira079
Copy link
Contributor

danieloliveira079 commented Nov 25, 2021

We should add Prometheus instrumentation to the controller in order to track the following metrics:

  • octops_ingress_reconcile_success: Counter for each reconcile event that succeeded
  • octops_ingress_reconcile_failed: Counter for each reconcile event that failed
  • octops_ingress_reconcile_duration_ms: Time taken to complete a reconcile event in milliseconds

The gameserver-ingress-controller should expose the [PORT]/metrics endpoint that will be scrapped by Prometheus. The implementation should be extensible and take into consideration that new metrics might be added to the future.

Refereces to the Prometheus instrumentation for Go applications can be found on https://prometheus.io/docs/guides/go-application/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants