Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TaskManager global, keep Task hook per GameObject #430

Open
Sygmei opened this issue Jul 21, 2022 · 1 comment
Open

Make TaskManager global, keep Task hook per GameObject #430

Sygmei opened this issue Jul 21, 2022 · 1 comment
Assignees
Labels
enhancement The issue should enhance an existing feature
Projects

Comments

@Sygmei
Copy link
Member

Sygmei commented Jul 21, 2022

There is no benefit to have one TaskManager per GameObject, it forces every GameObject to listen on Event.Game.Update which is killing performance.

We could just keep one Task hook per GameObject to have proper listener ids.

We could also have a global Task hook to allow librairies to create Tasks.

@Sygmei Sygmei added the enhancement The issue should enhance an existing feature label Jul 21, 2022
@Sygmei Sygmei self-assigned this Jul 21, 2022
@Sygmei Sygmei added this to To do in Version 0.5 via automation Jul 21, 2022
@Sygmei
Copy link
Member Author

Sygmei commented Jul 21, 2022

Maybe we don't actually need a global Task hook as it will make global Tasks alive as long as the game is running, instead we might need a way to dynamically attach OrphanTasks (defined in a separate module) to the current GameObject.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue should enhance an existing feature
Projects
Version 0.5
  
To do
Development

No branches or pull requests

1 participant