Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make so vili::validator::validate_tree validates the whole tree #424

Open
Sygmei opened this issue Jun 7, 2022 · 0 comments
Open

Make so vili::validator::validate_tree validates the whole tree #424

Sygmei opened this issue Jun 7, 2022 · 0 comments
Assignees
Labels
enhancement The issue should enhance an existing feature
Projects

Comments

@Sygmei
Copy link
Member

Sygmei commented Jun 7, 2022

Right now, as soon as vili::validator::validate_tree encounters an exception, it stops crawling the tree and raises the exception.

This is acceptable for now but when having huge files, it would be super useful to be able to validate all the issues at once.

The way it could be implemented is by returning a vili::node that contains all validation failures, the validate_tree function would become nothrow.

This could be especially useful in IDEs integration (being able to validate a vili file by using the official schema).

@Sygmei Sygmei added the enhancement The issue should enhance an existing feature label Jun 7, 2022
@Sygmei Sygmei added this to To do in Version 0.7 via automation Jun 7, 2022
@Sygmei Sygmei self-assigned this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue should enhance an existing feature
Projects
Version 0.7
  
To do
Development

No branches or pull requests

1 participant