Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to use falling clock edge as the active one. #84

Open
KrzysztofZyla opened this issue Aug 18, 2023 · 2 comments
Open

Add possibility to use falling clock edge as the active one. #84

KrzysztofZyla opened this issue Aug 18, 2023 · 2 comments

Comments

@KrzysztofZyla
Copy link

(This was discussed some time ago, via email)
Now only rising clock edge can be the active edge. In TbUtilPkg.vhd we have

constant CLK_ACTIVE : std_logic := '1' ;

And this value is used in procedures like WaitForTransaction, WaitForClock, CreateReset and others.
If subprograms using CLK_ACTIVE had this value passed as a parameter (CLK_ACTIVE as the default value) it would be possible to also use the falling clock edge as active.

@JimLewis
Copy link
Member

Are you thinking then pass it as an optional parameter? That might make sense for a number of them. I put the constant CLK_ACTIVE in there to remind me to think about how to make it more generic. For WaitForClock, maybe there should also be a WaitForRisingClock and WaitForFallingClock?

@KrzysztofZyla
Copy link
Author

Are you thinking then pass it as an optional parameter?

Yes. It would give the user an alternative to use them in that way without modifying OSVVM library sources.

maybe there should also be a WaitForRisingClock and WaitForFallingClock?

Didn't thought about it, but for sure WaitForRisingClock and WaitForFallingClock is self-explanatory and more intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants