Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: evaluation script #13

Closed
BennoKrojer opened this issue Apr 4, 2024 · 3 comments
Closed

Bug fix: evaluation script #13

BennoKrojer opened this issue Apr 4, 2024 · 3 comments

Comments

@BennoKrojer
Copy link

Hi Kai,

I just found a small bug in image_eval.py line 144 (

gt_caption = caption_dict[gt_img_name]
).

Can you change the line to:

gt_caption = list(caption_dict[gt_img_name].items())[1][1]

Right now it throws an error because the input is both the pre-edit and post-edit global description.

@drogozhang
Copy link
Member

Hi Benno,

Thanks for pointing it out, I will have a look with the modified code on my side later. If it works on my side I will update it as soon as possible!

Best,
Kai

@drogozhang
Copy link
Member

Hi Benno,

I think we should use local caption for evaluation so I guess the original code is correct for the local caption (I submitted an old version of the markdown). Please try to follow the updated evaluation README.md and let me know if this issue still happens!

Best,
Kai

@drogozhang
Copy link
Member

Close for inactivity, let me know if you have any other questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants