Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need Version Declaration [requirements.txt] #8

Open
acbuynak opened this issue Aug 26, 2021 · 1 comment
Open

Need Version Declaration [requirements.txt] #8

acbuynak opened this issue Aug 26, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@acbuynak
Copy link
Member

Noticed a dependency versioning issue that I would like to resolve and fix for this entire package. Setting up this issue to track progress.

Tasks:

  • Identify all non-ROS depencies used
  • Identify current version desired to use.
  • Write requirements.txt file to ensure correct versioning use. Potentially include in a setup.py file.
@acbuynak acbuynak added the bug Something isn't working label Aug 26, 2021
@acbuynak
Copy link
Member Author

OpenCV

Package name: cv2
Currently used versions:
4.2.0 requires format _, contours, _ = cv2.findContours()
3.2.0 requires format contours, _ = cv2.findContours()

Issue identified in commit 52d4ef5. The commit comment's root cause was incorrectly identified as a typo, real issue is that different versions of OpenCV handle this API call differently.

It is technically possible to write an if then, else type solution here, but I think we're better of picking a specific version and holding to it. I would suggest the newer version for longevity of the code.

@acbuynak acbuynak changed the title Dependencies Version Requirements Need Version Declaration [requirements.txt] Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants