Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighting changes the color only to black #239

Open
BatuhanCakir opened this issue Jun 22, 2021 · 5 comments
Open

Highlighting changes the color only to black #239

BatuhanCakir opened this issue Jun 22, 2021 · 5 comments

Comments

@BatuhanCakir
Copy link

Hi,
When i try to highlight sth it changes the color only to black.I am not sure if it is intended but on the website https://osmbuildings.org/?lat=52.52111&lon=13.41078&zoom=16.0&tilt=30 it also changes the olor only to black

@Alikhalesi
Copy link

I created a pull request for this problem and I am waiting for code review and merge the changes.
link: #231

@BatuhanCakir
Copy link
Author

ok ty i hope they will merge it

@ciarans
Copy link

ciarans commented Jul 2, 2021

Hey @Alikhalesi can you share how/where you fixed it? I’m trying to also not have the solid black colour.

Thanks!

@Alikhalesi
Copy link

hi @ciarans , check this link for file changes: https://github.com/OSMBuildings/OSMBuildings/pull/231/files
function clamp should change to


function clamp(value, min, max) {
	if(max===undefined)
	{
		return value;
	}
  return Math.min(max, Math.max(value, min));
} 

@outsidious
Copy link

I have the same problem. Hope you will fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants