Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: crontab: get rid of hardcoded versions in binary build job entries #760

Open
neteler opened this issue Jun 3, 2022 · 2 comments · May be fixed by #814
Open

[Bug]: crontab: get rid of hardcoded versions in binary build job entries #760

neteler opened this issue Jun 3, 2022 · 2 comments · May be fixed by #814

Comments

@neteler
Copy link
Member

neteler commented Jun 3, 2022

At time, the minor version is hardcoded in the crontab related to writing out the logs, e.g.:

15 05 * * * nice sh /home/neteler/cronjobs/cron_grass8_relbranch_build_binaries.sh > /var/www/code_and_data/grass82/binary/linux/snapshot/build.log.txt 2>&1

A solution is needed to avoid future editing with every minor release.

@ninsbl
Copy link
Member

ninsbl commented Oct 4, 2022

What about doing something like:

latest_release_branch=$(curl https://api.github.com/repos/osgeo/grass/branches | grep release | grep '"name":' | cut -f4 -d'"' | tail -n 1)

in the build script an then fetching major and minor version from the branch name?

GMAJOR=$(echo $latest_release_branch | cut -f2 -d"_")
GMINOR=$(echo $latest_release_branch | cut -f3 -d"_")

I can open a PR, if you think building upon the GitHub API is a good move...

@neteler
Copy link
Member Author

neteler commented Oct 5, 2022

I can open a PR, if you think building upon the GitHub API is a good move...

A PR would be appreciated!

@ninsbl ninsbl linked a pull request Oct 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants