Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error with dune-fem branch release/2.9 #4934

Open
blattms opened this issue Oct 17, 2023 · 2 comments
Open

Build error with dune-fem branch release/2.9 #4934

blattms opened this issue Oct 17, 2023 · 2 comments
Assignees

Comments

@blattms
Copy link
Member

blattms commented Oct 17, 2023

[  0%] Building CXX object CMakeFiles/opmsimulators.dir/ebos/collecttoiorank.cc.o
In file included from /home/mblatt/src/dune/opm-release-2.9/opm-simulators/ebos/collecttoiorank.cc:32:
/home/mblatt/src/dune/opm-release-2.9/dune-fem/dune/fem/gridpart/common/gridpart2gridview.hh:4:2: warning: #warning "This header should not be needed anymore. Remove it from the include list!" [-Wcpp]
    4 | #warning "This header should not be needed anymore. Remove it from the include list!"
      |  ^~~~~~~
In file included from /home/mblatt/src/dune/opm-release-2.9/opm-simulators/ebos/femcpgridcompat.hh:37,
                 from /home/mblatt/src/dune/opm-release-2.9/opm-simulators/ebos/collecttoiorank.cc:33:
/home/mblatt/src/dune/opm-release-2.9/dune-fem/dune/fem/misc/compatibility.hh:4:2: error: #error COMPATIBILITY HEADER SHOULD NOT BE USED ANYMORE: make_entity can be removed
    4 | #error COMPATIBILITY HEADER SHOULD NOT BE USED ANYMORE: make_entity can be removed
      |  ^~~~~
@blattms blattms added this to the Release 2023.10 milestone Oct 17, 2023
@blattms
Copy link
Member Author

blattms commented Oct 19, 2023

Maybe somebody using dune-fem more often could take a look? @atgeirr @ElyesAhmed @hnil

Might be as simple as stopping to use GridPart2GridView, see comment of Andreas Dedner at https://gitlab.dune-project.org/dune-fem/dune-fem/-/issues/170
Of course our backwards compatibility with 2.7 (is that correct?) might bite us here. But maybe for people using dune-fem supporting just 2.8 and 2.9 if dune-fem is there is good enough.

@blattms
Copy link
Member Author

blattms commented Oct 26, 2023

Like I said comments and work from people using dune-fem are highly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants