Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity's geometry is returned by constant reference #328

Open
berndflemisch opened this issue Jun 15, 2018 · 2 comments
Open

Entity's geometry is returned by constant reference #328

berndflemisch opened this issue Jun 15, 2018 · 2 comments

Comments

@berndflemisch
Copy link
Member

Apart from violating Dune's interface for already a very long time,
this can lead to errors, e.g., if you assume that the result of geometry() can be moved.
@blattms
Copy link
Member

blattms commented Jun 19, 2018

Seems a reasonable and performance innocent fix. Will provide a patch and test

@blattms blattms mentioned this issue Jun 19, 2018
Open
@berndflemisch
Copy link
Member Author

Works for me, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blattms @berndflemisch