Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved treatment of sources, injected and produced amounts in simulators. #403

Open
atgeirr opened this issue Oct 4, 2013 · 3 comments

Comments

@atgeirr
Copy link
Member

atgeirr commented Oct 4, 2013

#401 should solve the problems reported in #398 with the transport solver. However, the reports issued are still wrong, basically computeInjectedProduced() should be rewritten to fix this.

I suggest two changes that would make these things more robust:

  • Use some kind of source specification object to clearly specify for any injection source its phase, instead of using the somewhat magical 'transport source' convention (negative is total outflow, positive is first phase inflow).
  • Instead of trying to figure out after the face how much was injected or produced (as the function computeInjectedProduced() does now), which only can be correct for implicit methods, all transport solvers should instead report these numbers themselves.
@rolk
Copy link
Member

rolk commented Oct 4, 2013

all transport solvers should instead report these numbers themselves.

How do you envision that this reporting should take place? Should SimulatorReport be enhanced to contain field/methods to report these numbers into? I am not particularily fond of objects that burst out to cout/cerr from deep within a method.

@atgeirr
Copy link
Member Author

atgeirr commented Oct 4, 2013

By report I meant that the solvers should return some object with the required info, so the simulator class can choose to print it, I guess it was a little unclear. I did not intend that solvers should print more to the terminal.

I have not yet given much thought as to whether SimulatorReport would be the right place to put it.

@atgeirr atgeirr removed this from the Release 2015.10 milestone Oct 21, 2015
@atgeirr
Copy link
Member Author

atgeirr commented Oct 21, 2015

Another issue with the "Simulator toolbox" classes/systems. Removing from release milestone, keeping as a reminder, not actively working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants