Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent handling of PORV/MULTPV in EDIT section #4024

Open
blattms opened this issue Apr 22, 2024 · 0 comments
Open

Inconsistent handling of PORV/MULTPV in EDIT section #4024

blattms opened this issue Apr 22, 2024 · 0 comments
Labels

Comments

@blattms
Copy link
Member

blattms commented Apr 22, 2024

We have a test PORV in FieldPropsTests.cpp with:

EDIT

BOX
  1 10 1 10 4 4 /

MULTPV
  100*4 /

ENDBOX

BOX
  1 10 1 10 3 3 /

PORV
  100*3 /

ENDBOX

which has the expected result, because when getting PORV from the FieldProperties for writing the first time, we will calculate it from PORO, NTG, MULTPV and cell volume.

But if we put PORV before MULTPV, then the multiplier will not be accounted for and the test breaks, see #4023. Due to the non-overlapping boxes this should definitely be a problem.

What if the boxes overlap or are the same? Would order matter here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant