Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign flipping template subject variability #255

Open
matsvanes opened this issue Jan 10, 2024 · 1 comment
Open

sign flipping template subject variability #255

matsvanes opened this issue Jan 10, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@matsvanes
Copy link
Collaborator

matsvanes commented Jan 10, 2024

We're often processing data in batches - for whatever reason. However, if we iteratively use find_template_subject with different inputs, we have the risk of using different templates for sign-flipping different data.
Would it be an idea to add the following to find_template_subject - especially for when we interact with source_recon through the run_source_batch?

  1. check if the source directory contains sign_flip_template.txt
  2. If so, and if this subject folder is available load use this template subject (and add it to subjects for input to run_source_batch)
  3. if not, run find_template_subject as usual
  4. Of course we could add in an extra argument overwrite to not use the txt file
@matsvanes matsvanes added the enhancement New feature or request label Jan 10, 2024
@cgohil8
Copy link
Collaborator

cgohil8 commented Jan 11, 2024

Note, for anyone currently experiencing issues trying to align a dataset to a different already sign flipped dataset, there is an example using the low-level functions that can be used more flexibly:

https://github.com/OHBA-analysis/osl/blob/main/examples/sign_flipping.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants