Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osl_maxfilter doesn't work with --trans default #192

Open
matsvanes opened this issue Mar 30, 2023 · 4 comments · Fixed by #206
Open

osl_maxfilter doesn't work with --trans default #192

matsvanes opened this issue Mar 30, 2023 · 4 comments · Fixed by #206
Assignees
Labels
bug Something isn't working maxfilter

Comments

@matsvanes
Copy link
Collaborator

The documentation of the osl_maxfilter notes we can use
osl_maxfilter input_files.txt /path/to/my/output/dir/ --trans default --origin 0 0 40 --frame head --force
to align head position between recordings by aligning them to a pre-specified position.
However, these options are currently not supported.
Having 4 flags is currently also not possible, so @AJQuinn suggestion was to create a new option that refers to
default --origin 0 0 40 --frame head --force

@matsvanes matsvanes self-assigned this Mar 30, 2023
@matsvanes
Copy link
Collaborator Author

Should also include some documentation on the fact that this should be run separate to sss

@cgohil8
Copy link
Collaborator

cgohil8 commented Jul 3, 2023

@AJQuinn , @matsvanes

Does simply changing https://github.com/OHBA-analysis/osl/blob/main/osl/maxfilter/maxfilter.py#L453 to

stage3_args = {'autobad': None, 'force': True}

resolve this?

@cgohil8 cgohil8 mentioned this issue Jul 3, 2023
@cgohil8 cgohil8 linked a pull request Jul 3, 2023 that will close this issue
@cgohil8
Copy link
Collaborator

cgohil8 commented Jul 3, 2023

The above change will let you use -trans within the maxfilter command in OSL so i'm going to merge it in. This will close this issue. @matsvanes if the above change isn't the best approach for resolving this, re-open the issue.

@matsvanes matsvanes reopened this Jul 4, 2023
@matsvanes
Copy link
Collaborator Author

I think your changes fixed part of it, but I don't think it enables you to specify a particular origin. Namely, the origin has three flags, where only 1 is supported. I do wonder whether this is already (partly) implemented by run_cbu_3stage_maxfilter (https://github.com/OHBA-analysis/osl/blob/main/osl/maxfilter/maxfilter.py#L463), where a fixed origin is specified?

@cgohil8 cgohil8 added bug Something isn't working maxfilter labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maxfilter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants