Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coding for protection in tables #58

Open
SRGDamia1 opened this issue Apr 13, 2016 · 2 comments
Open

Remove coding for protection in tables #58

SRGDamia1 opened this issue Apr 13, 2016 · 2 comments

Comments

@SRGDamia1
Copy link
Member

In order to make adding lines to tables work while the tables were protected, I added several extra macros (see #18). Because we are no longer using excel itself to generate the YAML, there are many fewer formulas in the workbook. This may mean it's safe to leave the workbook unprotected ( #50 ). If we're going to do that, all of this code should be removed. It doesn't work perfectly anyway, and it crashes frequently.

This means removing the class module CFillProtectedLO and the private subs (and everything) in the "this workbook" object.

@horsburgh
Copy link
Member

Now that we have simplified, I think we should unprotect things. I think 0.3.2 of the Time Series template is unprotected now. As I was testing it, I think it was adding additional lines to the table OK, but I'm not sure all of the formatting was working correctly - particularly the bold border around the table.

@SRGDamia1 - You may have had that all figured out in your original versions and I may have messed it up when I did my updates.

@SRGDamia1
Copy link
Member Author

I think I had all of the other formatting fixed, but I don't remember specifically about the borders. I can look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants