Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit tests #180

Open
emiliom opened this issue Aug 30, 2017 · 2 comments
Open

Revisit tests #180

emiliom opened this issue Aug 30, 2017 · 2 comments

Comments

@emiliom
Copy link
Member

emiliom commented Aug 30, 2017

@ocefpaf today commented:

this made me realize that all the cbi tests are skipped anyways 馃槃
See https://travis-ci.org/ocefpaf/WOFpy/jobs/270205139#L915
Is that something we should look into?

Sure, but not right now! Those tests are not very important.

I'm opening this issue to remind us to give the test suite another look later on.

Ref: #179 and 27b25e8 (the latter disabled part of the cbi tests)

@lsetiawan
Copy link
Member

test_cli.py is still causing a build failure. as of now. https://travis-ci.org/ODM2/WOFpy/jobs/270272234#L1173

@ocefpaf
Copy link
Member

ocefpaf commented Aug 31, 2017

test_cli.py is still causing a build failure. as of now. https://travis-ci.org/ODM2/WOFpy/jobs/270272234#L1173

Hard to debug something that happens sporadically and I cannot reproduce locally 馃槥

I'll change the test logic to something simpler. It is only trying to check if the new directory has a different inode to ensure it is a new directory, but I have another (simpler) idea that might do the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants