Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions should have a name #135

Open
smrgeoinfo opened this issue Jun 24, 2017 · 11 comments
Open

Actions should have a name #135

smrgeoinfo opened this issue Jun 24, 2017 · 11 comments

Comments

@smrgeoinfo
Copy link

smrgeoinfo commented Jun 24, 2017

Because actions are being used to represent activities like cruises, alvin dives, field expeditions, other data acquisition initiatives, they should have a name.

@smrgeoinfo smrgeoinfo changed the title Actions should have a name and description Actions should have a name Jun 24, 2017
@horsburgh
Copy link
Member

horsburgh commented Jun 26, 2017

@smrgeoinfo - my comment from earlier about grouping things by "datasets" rather than trying to do everything via "actions" may be relevant here too.

@smrgeoinfo
Copy link
Author

The idea that the representation of an activity like a cruise/project/field expedition is represented in the database as a dataset is not appealing to me. Seems like it would create confusion about what 'dataset' is supposed to meaning, making it harder to explain using the schema to people.

@dr-shorthair
Copy link

Tend to agree with Steve here. In prov terms, a project or cruise is an activity which generates a dataset which is an entity. In bfo terms it's occurrent vs. continuant. It's likely to be confusing in the future to conflate these or make one a proxy for the other.

@PleiadesAustralia
Copy link

I have been having this problem with regard to Sampling Actions. Currently I need to save the SampleNumber as an ActionAnnotation. This seems to be dangerous as the sample number is an essential quality control identifier.

@emiliom
Copy link
Member

emiliom commented Jun 28, 2018

I also tend to agree with @smrgeoinfo's recommendation, specially when taking into account @dr-shorthair's observations about PROV. Cruises, expeditions and such are prominent concepts and parents to a lot of downstream results. Using Datasets to represent these things is awkward and frail, at least in part because as more results are generated from, say, samples collected by a cruise (often years after the cruise), the DatasetResults mapping would need to be updated. A parent action takes care of this cleanly. If adding an action name greatly facilitates this need, I'm all for it. It's a simple change, though one involving a very central schema entity.

During the development of my early and unfinished PRISM Cruises ODM2 use case, I represented cruises as both a sampling feature with a spatial representation, and the corresponding action that represented the execution of that cruise. The sampling feature instance enabled the storing of a code, name, and uri, while parent-child relationships on both sampling features and actions enabled hierarchical linkage to all "derived" actions and results. Such a tight samplingfeature-action linkage may not always be possible, and I can see that an action name would be helpful.

Regarding @PleiadesAustralia's comment:

Currently I need to save the SampleNumber as an ActionAnnotation. This seems to be dangerous as the sample number is an essential quality control identifier.

For that particular need, I would definitely point to the use of SamplingFeatures.SamplingFeatureCode (plus SamplingFeatures.SamplingFeatureName). That's exactly what SamplingFeatures.SamplingFeatureCode is for. You're dealing with samples, which in ODM2 lingo are "specimens", a prominent SamplingFeatures type.

@PleiadesAustralia
Copy link

PleiadesAustralia commented Jun 29, 2018 via email

@emiliom
Copy link
Member

emiliom commented Jun 29, 2018

Geospatial information in SamplingFeatures is not required. One of the reasons for this is precisely to support specimens like the ones you mention.

See the attributes of a Specimens entity., including the specimen type CV and the IsFieldSpecimen flag.

@PleiadesAustralia
Copy link

PleiadesAustralia commented Jun 29, 2018 via email

@aufdenkampe
Copy link
Member

@PleiadesAustralia, I completely agree with @emiliom regarding his suggestions for how to store your sample numbers.

@PleiadesAustralia
Copy link

PleiadesAustralia commented Aug 8, 2018 via email

aufdenkampe added a commit that referenced this issue Aug 8, 2018
@aufdenkampe
Copy link
Member

I really like the suggestion from @smrgeoinfo, and just implemented it in the ODM2.1_dev branch.

Here is the updated diagram reflecting f2bda09 and cumulative commits in the branch.

Note that I also moved ActionDescription up in the table, and I rearranged the ODM2Core diagram to align with the up-to-down & left-to-right cardinality conventions used in the ODM2OverviewSimplified diagram.

odm2core_odm2 1_dev_f2bda09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants