[BUG] Install EXE - executable.exe is missing (2.12.0)

[LMS235]

OCS Inventory version
Version : 2.12.0

Describe the bug
In 2.11.1 build a normal EXE: NAME="executable.exe /S /user=all"
In 2.12.0 build a normal EXE: NAME="/S /user=all" => "executable.exe" is missing => deployment won't work

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Deployment' => 'Build'
2. Click on 'Windows' => 'Install / Uninstall' => 'Execute an exe'
3. Create an EXE Install and see the info file....

Expected behavior
As of now, the whole deployment feature in 2.12.0 is not really functional (see also #1536). This must change as soon as possible!

[LMS235]

the error is in the adjustments in the file ~/ocsreports/require/teledeploy/PackageBuilder.php

fastest solution as workaround is to use the "old" file (PackageBuilder.php) from 2.11.1, then at least the deployment of Windows works clean again (EXE and CUSTOM EXE - #1536)

something between line 400 and 409 is wrong:

		if ($xmlDetails->packagedefinition->ACT  == 'LAUNCH' && $xmlDetails->formoption->ISCUSTOM == false) {
			// if pkg built from linux bashscript option and not custom package, 
			// default retrieved if a command but w/ LAUNCH, the agent will be expecting a name
			$name = substr($xmlDetails->packagedefinition->COMMAND, strpos($xmlDetails->packagedefinition->COMMAND, ' ') + 1);
			$info .= "NAME=\"" . $name . "\" ";

		} else if ($xmlDetails->packagedefinition->ACT  == 'LAUNCH') {
            $info .= "NAME=\"" . $xmlDetails->packagedefinition->COMMAND . "\" ";
        }

[charleneauger]

Hi @LMS235 ,

I made some fixes related to your issues.
You will find them in the following PR : #1542

Best regards,
Charlene

[LMS235]

tested --> work