[16.0] Missing key in search panel filter component OWL

[DuyDangHTEN]

Module

web_responese

Describe the bug

Missing key in search panel filter component OWL in file:
web_responsive/static/src/components/search_panel/search_panel.xml
<span t-foreach="filters" t-as="filter" class="mx-1">

This cause view with search panel filter raise error missing 't-key'.
UncaughtPromiseError > OwlError Uncaught Promise > "Directive t-foreach should always be used with a t-key!" (expression: t-foreach="filters" t-as="filter")

To Reproduce

Affected versions: 16.0

1. Create a view tree with js_class using legacy views.
2. Open the view.

Expected behavior
Should have 't-key'
<span t-foreach="filters" t-as="filter" t-key="filter.type" class="mx-1">

[idenayer]

Hello @pedrobaeza , can I work on this please?

[pedrobaeza]

Of course! You don't need to ask for permission for contributing 😃

[idenayer]

Hi @DuyDangHTEN , do you have a specific legacy view tree in mind for me to reproduce the issue?

[DuyDangHTEN]

@idenayer

view.js

/** @odoo-module **/

import ListView from 'web.ListView';
import legacyViewRegistry from 'web.view_registry';

legacyViewRegistry.add('list_test', ListView);

view.xml (Sale for example)

<odoo>
    <record id="view_sales_order_filter_extend" model="ir.ui.view">
            <field name="name">sale.order.view.filter.extend</field>
            <field name="model">sale.order</field>
            <field name="inherit_id" ref="sale.view_sales_order_filter"/>
            <field name="arch" type="xml">
                 <search>
                    <searchpanel>
                        <field name="state"/>
                    </searchpanel>
                </search>
            </field>
    </record>

    <record id="view_sale_order_extend" model="ir.ui.view">
        <field name="name">sale.order.tree.extend</field>
        <field name="model">sale.order</field>
        <field name="inherit_id" ref="sale.view_quotation_tree_with_onboarding"/>
        <field name="arch" type="xml">

            <xpath expr="//tree" position="attributes">
                <attribute name="js_class">list_test</attribute>
            </xpath>

        </field>
    </record>
</odoo>