Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16] sale_order_type: cannot edit the partner_bank_id #3074

Open
rrvc12 opened this issue Apr 16, 2024 · 1 comment
Open

[16] sale_order_type: cannot edit the partner_bank_id #3074

rrvc12 opened this issue Apr 16, 2024 · 1 comment
Labels

Comments

@rrvc12
Copy link

rrvc12 commented Apr 16, 2024

Module

sale_order_type

Describe the bug

Cannot save an option other than the first bank account (computed field logic) in the partner_bank_id field of account payments.

To Reproduce

16.0

Steps to reproduce the behavior:
https://www.loom.com/share/a4b89edfaf634a00a48cca1ed460e6a6

Expected behavior
I should be able to choose the bank account I prefer, maybe the second or third

Additional context
According to my analysis, this module adds a sale_type_id field in the account_move that is added as a dependency in the method _compute_journal_id which affects the _compute_partner_bank_id method because the journal_id is involved, the _compute_partner_bank_id always execute and place the same account

method added by the module
image
url: https://github.com/OCA/sale-workflow/blob/53dd5cdc6a196cbb173ddf4d94c84230a1eb621b/sale_order_type/models/account_move.py#L61

computed in account_payment
image
url: https://github.com/odoo/odoo/blob/65a19492a8044be4f05a8200a6956c3e50b69eab/addons/account/models/account_payment.py#L418

@CILC98
Copy link

CILC98 commented Apr 22, 2024

With this PR we hope to solve the problem: #3089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants