Bug in action_confirm of sale_quotation_number module

[lorenzoallegrucci]

Module

sale_quotation_number

Describe the bug

On line 46 https://github.com/OCA/sale-workflow/blob/14.0/sale_quotation_number/models/sale_order.py#L46
it should be:
if order.name[:2] != "SQ": but the actual code is referring self.name

Moreover, can anyone explain me what is the goal of this hardcoded "SQ" check?
Wouldn't be better to compare ir.sequence prefix?

To Reproduce

Affected versions: 14.0, 16.0

[OpenCode]

#2126

[simoneversienti]

I agree with @lorenzoallegrucci .
Check on hardcoded string "SQ" can be a big limitation (and causes bug) for env where the default sale.quotation (SQ) sequence is not used