Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Add id_token support to OAuthSwiftCredential #668

Open
5 of 20 tasks
MikeSpelling opened this issue Jul 13, 2021 · 1 comment
Open
5 of 20 tasks

Comments

@MikeSpelling
Copy link

Description:

In order to support single-sign out with a redirect endpoint you need access to the original id_token received during authentication (https://identityserver4.readthedocs.io/en/latest/endpoints/endsession.html#refendsession).
It seems like this should be easy enough to add to the OAuthSwiftCredential object as an optional String.
Around line 122 of OAuth2Swift for example (where the access_token is set) the id_token could also be added?

OAuth Provider? (Twitter, Github, ..):

Custom - using our own Identity Server

OAuth Version:

  • Version 1
  • Version 2

OS (Please fill the version) :

  • iOS :
  • OSX :
  • TVOS :
  • WatchOS :

Installation method:

  • Carthage
  • CocoaPods
  • Swift Package Manager
  • Manually

Library version:

  • head
  • v2.1.0
  • v2.0.0
  • v1.4.1
  • other: (v2.2.0)

Xcode version:

  • 11.4 (Swift 5.2)
  • 11.x (Swift 5.1)
  • 10.x (Swift 5.0)
  • other: (Xcode 12.5.1, Swift 5.4)
  • objective c
@colinhumber
Copy link
Contributor

I've added support for this in #679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@colinhumber @MikeSpelling and others