Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReSpec HTML generation needs to use correct revision of MAINTAINERS.md #3693

Closed
handrews opened this issue Apr 3, 2024 · 3 comments · Fixed by #3782
Closed

ReSpec HTML generation needs to use correct revision of MAINTAINERS.md #3693

handrews opened this issue Apr 3, 2024 · 3 comments · Fixed by #3782

Comments

@handrews
Copy link
Contributor

handrews commented Apr 3, 2024

As seen in PR #3688, scripts/md2html fails to use the correct revision of the MAINTAINERS.md file for the 3.0 and 3.1 specifications. Specifically, build.sh uses a specific revision for the 2.0 spec, but not for the later specs. Also, the collection of emeritus members in md2html.js seems to no longer work with the current file format.

@lornajane
Copy link
Contributor

Would it make sense to version the maintainer files?

@ralfhandl
Copy link
Contributor

The build script expects "Emeritus" to be the second unordered list:

u = $('ul').eq(1);
$(u).children('li').each(function(e){
let t = $(this).text().split('@')[0];
emeritus.push({name:t});
});

Now the second list is "Provisional".

Should provisional maintainers be

  1. ignored, or
  2. treated identical to "Active"?

@ralfhandl
Copy link
Contributor

ralfhandl commented May 6, 2024

Special case for version 2.0 is incorrect as the history of Maintainers.md starts too late, and the first commit already lists two members as "Emeritus" who were still active when version 2.0 was published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants